melpa / package-build

Tools for assembling a package archive
https://github.com/melpa/melpa
25 stars 34 forks source link

Compilation lint error re. use of rassq-delete-all #82

Closed purcell closed 1 year ago

purcell commented 1 year ago

Hey @tarsius, I see that the build fails for emacs HEAD due to the following new compilation error:

Compiling package-build.el

In toplevel form:
package-build.el:1219:31: Error: value from call to ‘assq-delete-all’ is unused
make: *** [Makefile:32: package-build.elc] Error 1

I wasn't sure if the correct fix was just to assign the result back to the let-bound var locally, or if it indicates an issue with the logic. Any idea?

tarsius commented 1 year ago

Mostly harmless; but we are dealing with a wacky api and encoding issues, so its worth a few comments.

purcell commented 1 year ago

Nice, makes sense, thanks!