Add height to table of contents and scroll on overflow

meltano / handbook

Source for Meltano's public handbook (https://handbook.meltano.com/) and public issue tracker for process and policy proposals that will be documented there.

MIT License

3 stars 4 forks source link

Add height to table of contents and scroll on overflow #416

Closed leoroese closed 1 year ago

leoroese commented 1 year ago

The table of contents on a couple of pages seemed to overflow into the footer and make it difficult to use the table of contents to navigate. I Added a height to the table of contents calculated by (100vh - navbar - extra scroll padding - footer) so that the table of contents should always persist above the footer on scroll.

Pages where this happened:

Anti-Harassment Policy
Tech Stack
DATA TEAM / SQL Style Guide
Stable increments

I have attached some before and after photos to show what it looks like

netlify[bot] commented 1 year ago

Deploy Preview for meltano-handbook ready!

Name	Link
Latest commit	cd5f3a1ae2ad706cb49d438db2274d898604efd3
Latest deploy log	https://app.netlify.com/sites/meltano-handbook/deploys/647fba02c518010008803d2e
Deploy Preview	https://deploy-preview-416--meltano-handbook.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

therebbie commented 1 year ago

@leoroese -- looks good to me. Thanks!

meltano / handbook

Add height to table of contents and scroll on overflow #416

✅ Deploy Preview for meltano-handbook ready!

Deploy Preview for meltano-handbook ready!