search

meltano / sdk

Write 70% less code by using the SDK to build custom extractors and loaders that adhere to the Singer standard: https://sdk.meltano.com
https://sdk.meltano.com
Apache License 2.0
94 stars 66 forks source link

Cast environment variables config values into their respective JSON schema type #390

Open MeltyBot opened 2 years ago

MeltyBot commented 2 years ago

Migrated from GitLab: https://gitlab.com/meltano/sdk/-/issues/393

Originally created by @edgarrmondragon on 2022-05-20 18:16:14

Summary

Currently only arrays of strings are parsed: value1,value2 -> ["value1", "value2"]. A similar process for number, boolean and integer would be valuable.

Proposed benefits

Proposal details

We already have some functions to check for data types in https://gitlab.com/meltano/sdk/-/blob/main/singer_sdk/helpers/_typing.py, so we could extend and leverage those when parsing environment variables.

Best reasons not to build

Support for environment variables is not common in the Singer ecosystem.

MeltyBot commented 2 years ago

View 1 previous comment from the original issue on GitLab

stale[bot] commented 1 year ago

This has been marked as stale because it is unassigned, and has not had recent activity. It will be closed after 21 days if no further activity occurs. If this should never go stale, please add the evergreen label, or request that it be added.

edgarrmondragon commented 1 year ago

Very much still relevant. See https://github.com/ryan-miranda-partners/tap-jira-sdk/pull/15#issuecomment-1640496601

stale[bot] commented 1 month ago

This has been marked as stale because it is unassigned, and has not had recent activity. It will be closed after 21 days if no further activity occurs. If this should never go stale, please add the evergreen label, or request that it be added.