search

memberapp / FeelsTheme

GNU Affero General Public License v3.0
6 stars 3 forks source link

Add different color for visited link #76

Closed FreeTrade closed 4 years ago

imjoshellis commented 4 years ago

Found this while trying to find issues to contribute to... Are you still looking for something here? If so, any details?

FreeTrade commented 4 years ago

Sure, we've got the colors specified at the top of base.css -

https://github.com/memberapp/memberapp.github.io/blob/master/css/base.css

You could review and suggest improvements - maybe there are too many colors, or too few, or complimenting or contrasting colors could be better selected.

imjoshellis commented 4 years ago

@FreeTrade

Any guidelines for what "improving" means? Examples via other sites?

One thing at first look is I would suggest adding visited styling (and maybe hover effects?) to links (especially .title) so it's more obvious what you've already visited:

Preview

Thoughts?

Real-FEELS commented 4 years ago

@FreeTrade current link formatting is like this:

<div class="title" onclick="if(document.getSelection().type === 'Range'){return;}else{location.href='#thread?root=4ab104b5f1a9f7aefa10d0e9174aab0a9e78b7ac30890470896a0a40a62534d5&amp;post=4ab104b5f1a9f7aefa10d0e9174aab0a9e78b7ac30890470896a0a40a62534d5'};">
            <p>... </p>
</div>

CSS :visited selector does not work on these links. Suggest adding a class to the link if the user has visited the link before. Save it in local storage. This could be a privacy issue so I suggest you also add a toggle in the settings for this feature.

FreeTrade commented 4 years ago

Thanks. I don't think js has access to this information for privacy reasons, so maybe we can't do this at all.