[main < T279] Turn Docker into an optional dependency - Githubissues

memgraph / gqlalchemy

GQLAlchemy is a library developed with the purpose of assisting in writing and running queries on Memgraph. GQLAlchemy supports high-level connection to Memgraph as well as modular query builder.

https://pypi.org/project/gqlalchemy/

Apache License 2.0

227 stars 32 forks source link

[main < T279] Turn Docker into an optional dependency #279

Closed antepusic closed 1 year ago

antepusic commented 1 year ago

Description

This PR converts Docker from a dependency into an extra, on account of the docker package itself depending on the vulnerable pywin32 package.

Pull request type

[x] Build or packaging related changes

Related issues

Closes #261

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

######################################

Reviewer checklist (the reviewer checks this part)

[ ] Core feature implementation
[ ] Tests
[ ] Code documentation
[ ] Documentation on gqlalchemy/docs

######################################

katarinasupe commented 1 year ago

Looks okay. Update README and docs in new PR. I will generate new reference guide 😄