mendixlabs / rich-text

MOVED to:
https://github.com/mendix/widgets-resources/tree/master/packages-web/rich-text
Apache License 2.0
2 stars 8 forks source link

Widget generates error in IE #28

Closed royhermans closed 5 years ago

royhermans commented 5 years ago

Hi Andries,

A user reported an error generated by this widget. After some research it turns out that user is using Internet Explorer. Turns out to be the same issue as reported in issue #23 .

I have updated the widget and now I get a pop-up stating "Failed to sanitize text, please use an other browser ". Is this something that can or will be fixed for Internet Explorer? The problem does not occur in Edge, Chrome, etc.

If you want I can also upload a test project in which I am able to replicate the issue.

Thank you in advance!

Kind regards,

Roy Hermans

diego-antonelli commented 5 years ago

Hi @royhermans can you please comment here your html content?

royhermans commented 5 years ago

Hi @diego-antonelli ,

I'm not sure what you want/how to do this, could you describe the steps to me? I can also add the test project so you can reproduce it yourself as well.

diego-antonelli commented 5 years ago

Hi @royhermans, we are facing an issue with % inside URLs just in IE and Edge till version 16.

Cause: IE and Edge are expecting for URL Entities in elements. So for IE and Edge just % is wrong, they are expecting %20 or another URL Entity. Chrome and Firefox just ignore single %.

Suggestion: What I can suggest for you is change the pattern of your replacedVar from {%varName%} to just {varName} and also in your configurations to replace, remove the %.

You can see more here: https://www.w3schools.com/tags/ref_urlencode.asp

royhermans commented 5 years ago

Hi @diego-antonelli , I am not sure we are understanding eachother correctly. I am not using any %'s or even URL's.

I checked a bit more and managed to narrow it down a bit: The error occurs when viewing the Rich Text Widget non-editable in a list-view.

screenshot_67

When you view the object on a page containing the non-editable Rich Text widget you do not get any errors.

screenshot_68

I have also uploaded the test project, just create a new object, enter some random text in the Rich Text Widget and save. The use the Overview Listview page to view the error in Internet Explorer.

RichTextIE_error.zip

I hope this clarifies things.

Andries-Smit commented 5 years ago

This issue is resolved in version 1.3.3 and is now available trough the app store