Const speedups, fix Brent initial conditions

mentat-collective / emmy

The Emmy Computer Algebra System.

https://emmy.mentat.org

GNU General Public License v3.0

405 stars 24 forks source link

Const speedups, fix Brent initial conditions #175

Closed sritchie closed 5 months ago

sritchie commented 6 months ago

This PR:

Adds ^:const metadata to all constants, reaping small performance wins
Updates emmy.numerical.unimin.brent/{brent-min,brent-max,brent-min-commons,brent-max-commons} to:
- take a new :initial-guess argument, useful if you have some idea of where the minimum might lie
- swaps the relative and absolute threshold defaults to match those from scmutils
- adjusts the initial guess from the midpoint between a and b to a golden section cut (closer to a), to match scmutils

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.69%. Comparing base (85af590) to head (3a3ad9f).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #175 +/- ## ========================================== + Coverage 87.67% 87.69% +0.02% ========================================== Files 99 99 Lines 15792 15802 +10 Branches 850 850 ========================================== + Hits 13845 13857 +12 + Misses 1097 1095 -2 Partials 850 850 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sritchie commented 5 months ago

@littleredcomputer I'm going to go ahead and merge this so we can get the bug fix out... let me know if you see any issues on review that you'd like me to tackle.

sritchie commented 5 months ago

@alexgian this is now merged! I'll have to do a little more work to get this out into the emmy-viewers bundle and make it available on Maria / in the viewers... but you can give it a try via the Clerk route now if you use Emmy as a git dependency.