search

mercure-imaging / mercure

mercure DICOM Orchestrator
https://mercure-imaging.org
MIT License
65 stars 31 forks source link

XNAT target ping problem #55

Closed aarontovars closed 11 months ago

aarontovars commented 1 year ago

Describe the bug After the merge from #54 , some small commits were done. One of them (commit 2f6f1de) changed the code to test if ping is OK. Before this change, if connection to XNAT was successful, ping was OK but after this commit, even though ping is OK, test is not passed and ping appears as None.

tblock79 commented 1 year ago

Can you provide more information on this? The previous code wasn't actually pinging the target host, so even if a server responded to ping requests, it wasn't showing the correct result.

While I don't have an XNAT instance running here, at least the pinging test seems to work correctly (and I don't see how the code would break things).

image

Where do you get the described "ping appears as None"?

tblock79 commented 11 months ago

Closing this due to inactivity.