Closed 0x5e closed 1 year ago
Thanks for that! Left one comment.
Updated, MiotDevice.isConnectedToCloud
should return boolean, and since miCloudDeviceInfo
is always an object so I use Object.keys(xxx).length > 0
to return the boolean, is it okay?
Let me double check that by myself tonight... I til then we leave the pull request open, ok?
Thanks!
Yes :)
Ok i have corrected the isConnectedToCloud flag now correctly. Please re-check if everything now works as expected without any errors :)
Ok, I will confirm on the weekend when I am at home.
It's working as expected :)
Related to #393 . Fix the warning of
characteristic value expected boolean and received object
And add the missing brightness return value