search

merdok / homebridge-miot

Homebridge plugin for devices supporting the Xiaomi miot protocol
MIT License
383 stars 62 forks source link

Fix speak on and volume not working #394

Closed 0x5e closed 1 year ago

0x5e commented 1 year ago

Related to #393 . Fix the warning of characteristic value expected boolean and received object And add the missing brightness return value

merdok commented 1 year ago

Thanks for that! Left one comment.

0x5e commented 1 year ago

Updated, MiotDevice.isConnectedToCloud should return boolean, and since miCloudDeviceInfo is always an object so I use Object.keys(xxx).length > 0 to return the boolean, is it okay?

merdok commented 1 year ago

Let me double check that by myself tonight... I til then we leave the pull request open, ok?

Thanks!

0x5e commented 1 year ago

Yes :)

merdok commented 1 year ago

Ok i have corrected the isConnectedToCloud flag now correctly. Please re-check if everything now works as expected without any errors :)

0x5e commented 1 year ago

Ok, I will confirm on the weekend when I am at home.

0x5e commented 1 year ago

It's working as expected :)