search

merdok / homebridge-miot

Homebridge plugin for devices supporting the Xiaomi miot protocol
MIT License
383 stars 62 forks source link

added support for the Viomi Kick-Line heater Pro2 #407

Closed gazer000 closed 1 year ago

gazer000 commented 1 year ago

Since some heaters (like the Viomi Kick-Line Heater) doesn't support environment:temperature properties, temperature readings on Apple Home when the device is turned on will be 0. These devices instead publish their temperature readings through heater:temperature property and this will need to be displayed instead.

merdok commented 1 year ago

Thanks for the PR. I left you a comment in the code.

gazer000 commented 1 year ago

Thanks for the PR. I left you a comment in the code.

Thanks for replying but I can't find your comment anywhere

merdok commented 1 year ago

Ah, sorry... forgot to submit it. Now you should be able to see it

gazer000 commented 1 year ago

I'll test this change and report back

merdok commented 1 year ago

Ok, please let me know. When it works then we can merge it.

gazer000 commented 1 year ago

Ok, please let me know. When it works then we can merge it.

Works okay now IMG_0372

merdok commented 1 year ago

Great to hear! Thanks for the PR!