Open heaths opened 3 months ago
Using F12 tools I see that namespace
s use the cluster
class but none of the documented cluster*
theme variables work e.g.,
---
config:
theme: base
themeVariables:
clusterBkg: magenta
clusterBorder: magenta
---
I've tried every theme variable even for other charts to no avail. Seems like a classDiagram
's namespace
border and background just isn't themeable without having to use CSS, which doesn't work on GitHub.
Still an issue in the new v3 unified renderer.
@yari-dewalt Previously this was possible to override by CSS. Now, the namespace's stroke gets !important
so even that is not possible anymore. Is there some other way to set the color? Thanks!
I wanted to add that CSS on GitHub doesn't work but seemingly only for Safari. See https://github.com/heaths/ordinal-rs/blob/main/README.md#performance in Edge (source: https://github.com/heaths/ordinal-rs/blob/main/docs/suffix_violin_plot.svg) (white text, polylines) vs. Safari (black text, polylines).
Still, if the theming was correct I wouldn't need to resort to CSS, which appears to have its own problems...and I tried several ways of inlining the CSS, all to no avail.
Just created a fix for this issue where the theming will work as expected #6026. @jacbz As far as I know and have tested there aren't any other ways possible for now due to what you said with the !important
keyword. This was a result of how the new rendering method applies styles. Once this fix is in we won't have to resort to using CSS.
@yari-dewalt thanks! Any guess as to how long after the fix is merged - and perhaps a release created - would GitHub pick it up? Does this project have a contact to alert them of the fix or do they pick up regular updates?
@heaths From what I've seen GitHub typically picks up new releases about a month after they are released. I'm not aware of any contact, so I assume they just pick up regular updates but I can ask around!
A month or so isn't so bad. This isn't critical. I just figured if it was, like, a year or "with cause" we could reach out. I know a few people there as well that could probably forward on a request to update to the right team.
Description
The black lines (strokes) in a class diagram for namespaces are very difficult to see in a dark theme. I've tried setting every plausible
themeVariables
value but nothing helps that, and in GitHub any<style>
tags are encoded (not kept as-is) so I can't restyle them according to your docs. It would be great if these were the same stroke color, by default, as otherrect
s.Steps to reproduce
Define a
class
diagram e.g.,Screenshots
See https://gist.github.com/heaths/4f22611744e97c5768bf34fe92894cd3:
Code Sample
Setup
Suggested Solutions
Make the
namespace
line the same color asclass
lines.Additional Context
GitHub seems to use a darker theme than the online editor, but even in the latter the black lines are hard to see. If the dark theme had more visible lines it wouldn't matter in either host.