search

meshcat-dev / meshcat-python

WebGL-based 3D visualizer for Python
MIT License
259 stars 63 forks source link

zmqserver can cache objects #75

Closed RussTedrake closed 4 years ago

RussTedrake commented 4 years ago

If the zmqserver gets a set_object command that sets precisely the same object data on precisely the same path that already exists, then do not forward it to the connected websockets.

This makes a dramatic improvement in the workflow of using meshcat on colab (at least as we use it in drake), because we don't have to repeatedly download large meshfiles from repeated simulations.

codecov-commenter commented 4 years ago

Codecov Report

Merging #75 into master will decrease coverage by 0.14%. The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #75      +/-   ##
==========================================
- Coverage   75.98%   75.83%   -0.15%     
==========================================
  Files          11       11              
  Lines        1012     1014       +2     
==========================================
  Hits          769      769              
- Misses        243      245       +2
Impacted Files Coverage Δ
src/meshcat/servers/zmqserver.py 32.78% <0.00%> (-0.28%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c1a0702...f9b43a2. Read the comment docs.