Feat: Converting Hamburger icon to cross in Navbar after clicking

meshery / meshery.io

Website for Meshery

https://meshery.io

Apache License 2.0

517 stars 587 forks source link

Feat: Converting Hamburger icon to cross in Navbar after clicking #1894

Open upsaurav12 opened 2 months ago

upsaurav12 commented 2 months ago

Description

Navbar in smaller width has toggle button but i want to convert that icon(Hamburger) to Cross after clicking to toggle button

Expected Behavior

It should be converted to cross

Screenshots

Environment:

OS: Mac Linux Windows
Browser: Chrome Safari Firefox
Version:
Device: Desktop Mobile

Contributor Guides and Handbook

The meshery.io website uses Jekyll and GitHub Pages. Site content is found under the master branch.

📚 See the Contributing to Meshery.io Website section of the readme.md and other contributing instructions, too.
🎨 Wireframes and designs for Meshery UI in Figma (open invite)
🙋🏾🙋🏼 Questions: Discussion Forum and Community Slack

welcome[bot] commented 2 months ago

Thanks for opening this issue. A contributor will be by to give feedback soon. In the meantime, please review the Newcomers' Guide and sure to join the community Slack.

upsaurav12 commented 2 months ago

@Ashparshp I have opened the issue

Ashparshp commented 2 months ago

@upsaurav12, are you working on this issue? If not, we can open it up for new contributors to work on.

upsaurav12 commented 2 months ago

I think it should be open for new contributor. @Ashparshp

anniepauline commented 2 months ago

Wanna work on it

Ashparshp commented 2 months ago

Thank you, @anniepauline! Issue assigned to you. Go ahead! 🚀

aliciacilmora commented 2 months ago

Wanna work on it

upsaurav12 commented 2 months ago

Thank you, @anniepauline! Issue assigned to you. Go ahead! 🚀

Thanks @Ashparshp

upsaurav12 commented 2 months ago

Wanna work on it

This issue was already assigned to someone you can try on other issues out there .

Ashparshp commented 2 months ago

@anniepauline, any luck?

Ashparshp commented 1 month ago

@anniepauline, still working on it?

GuraaseesSingh commented 1 month ago

@Ashparshp Is the contributor still working on the assigned issue. If not, I’d be happy to fix it.

Ashparshp commented 1 month ago

@GuraaseesSingh, thanks please go ahead..

GuraaseesSingh commented 1 month ago

@Ashparshp Perfect, I will go ahead and update you timely. Thank you

upsaurav12 commented 1 month ago

When i was working on this issue it was not reflecting the changes that i am making.

stale[bot] commented 3 days ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

upsaurav12 commented 3 days ago

Hi @Ashparshp can i take this issue ?

GuraaseesSingh commented 3 days ago

Would do a pr by tomorrow.