search

meshtastic / python

The Python CLI and API for talking to Meshtastic devices
https://meshtastic.org
410 stars 170 forks source link

Code block unreachable #659

Closed wnagele closed 2 months ago

wnagele commented 2 months ago

Cleaning up a code block that clearly will never execute.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 61.66%. Comparing base (abf9e96) to head (e725292). Report is 5 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #659 +/- ## ========================================== + Coverage 61.63% 61.66% +0.03% ========================================== Files 24 24 Lines 3597 3592 -5 ========================================== - Hits 2217 2215 -2 + Misses 1380 1377 -3 ``` | [Flag](https://app.codecov.io/gh/meshtastic/python/pull/659/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=meshtastic) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/meshtastic/python/pull/659/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=meshtastic) | `61.66% <ø> (+0.03%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=meshtastic#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ianmcorvidae commented 2 months ago

Good catch, thanks!