meshtastic / python

The Python CLI and API for talking to Meshtastic devices
https://meshtastic.org
410 stars 170 forks source link

Don't automatically set the time from Python #663

Closed jp-bennett closed 2 months ago

jp-bennett commented 2 months ago

The Python MO is to do as little as possible beyond what the user has intentionally instructed. So don't try to set the time automatically.

jp-bennett commented 2 months ago

Tangentially related to firmware/#4589

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 61.63%. Comparing base (bcce568) to head (5c312be). Report is 6 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #663 +/- ## ========================================== - Coverage 61.67% 61.63% -0.05% ========================================== Files 24 24 Lines 3593 3589 -4 ========================================== - Hits 2216 2212 -4 Misses 1377 1377 ``` | [Flag](https://app.codecov.io/gh/meshtastic/python/pull/663/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=meshtastic) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/meshtastic/python/pull/663/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=meshtastic) | `61.63% <ø> (-0.05%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=meshtastic#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ianmcorvidae commented 2 months ago

Seems alright to me. I'll merge it and add an extra commit to make --no-time a no-op (with just this change it'll still send a position, just not with a time). We can add a --set-time that uses the new admin command in 2.5+