meshtastic / python

The Python CLI and API for talking to Meshtastic devices
https://meshtastic.org
410 stars 170 forks source link

Add other telemetry variants to automatic handling/adding to node information #685

Closed ianmcorvidae closed 1 month ago

ianmcorvidae commented 1 month ago

This PR makes it so that the other telemetry variants (not just device_metrics) will end up in corresponding spots within interface.nodes and interface.nodesByNum. As is usual here, they'll be camelcased, so parallel to deviceMetrics is environmentMetrics, airQualityMetrics, powerMetrics, and localStats.

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 0% with 21 lines in your changes missing coverage. Please review.

Project coverage is 60.81%. Comparing base (6b9db7a) to head (33fecbd). Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
meshtastic/__init__.py 0.00% 21 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #685 +/- ## ========================================== - Coverage 61.04% 60.81% -0.23% ========================================== Files 24 24 Lines 3748 3762 +14 ========================================== Hits 2288 2288 - Misses 1460 1474 +14 ``` | [Flag](https://app.codecov.io/gh/meshtastic/python/pull/685/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=meshtastic) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/meshtastic/python/pull/685/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=meshtastic) | `60.81% <0.00%> (-0.23%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=meshtastic#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.