mesmo-dev / mesmo

MESMO - Multi-Energy System Modeling and Optimization
https://mesmo-dev.github.io/mesmo
MIT License
48 stars 12 forks source link

DER Marginal Cost: Wrong Unit #21

Open stroitzsch opened 2 years ago

stroitzsch commented 2 years ago

Marginal cost values of DERs are not properly converted to match the unit of the source price time series.

Thanks @miladkzm for reporting!

miladkzm commented 2 years ago

Hi Sebastian, I hope you are doing well. I downloaded the latest version of mesmo and I found out that as I had reported earlier the DER's marginal cost unit is not in 1/Wh as for price_timeseries but it is in 1/kWh.

So, I guess the line 146 in der_model.py should be replaced by the following:

self.marginal_cost = der.at["marginal_cost"] / 1e3 * der_data.scenario_data.scenario.at["base_apparent_power"] \ if pd.notnull(der.at["marginal_cost"]) else 0.0

BR, Milad