Build failure in latest master

[krish7919]

I had to check out the latest release for successful build.

ubuntu@ip-172-31-17-54:~/kafka⟫ ./gradlew jar
:compileJava UP-TO-DATE
:compileScala
[ant:scalac] /home/ubuntu/kafka/src/scala/ly/stealth/mesos/kafka/BrokerServer.scala:241: error: value join is not a member of object String
[ant:scalac]       String.join(",", nameParts)
[ant:scalac]              ^
[ant:scalac] one error found
:compileScala FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':compileScala'.
> Compile failed with 1 error; see the compiler error output for details.

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.
BUILD FAILED
Total time: 17.284 secs

[steveniemitz]

Weird, it compiles fine for me (I added that change).

~/dev/kafka-mesos (master) $ ./gradlew clean jar
Picked up _JAVA_OPTIONS: -Djava.net.preferIPv4Stack=true
:clean
:compileJava UP-TO-DATE
:compileScala
:processResources UP-TO-DATE
:classes
:compileTestJava UP-TO-DATE
:compileTestScala
[ant:scalac] Element '/Users/sniemitz/dev/kafka-mesos/out/gradle/resources/main' does not exist.
:processTestResources UP-TO-DATE
:testClasses
:test
Picked up _JAVA_OPTIONS: -Djava.net.preferIPv4Stack=true
:jar

BUILD SUCCESSFUL

Total time: 33.203 secs

What version of java/scala are you using? In any case though, I have a pull request out already that'll remove that code.

Edit: looks like String.join was added in java 8, I guess you need that to build?

[krish7919]

I have:

~/kafka⟫ java -version
java version "1.7.0_101"
OpenJDK Runtime Environment (IcedTea 2.6.6) (7u101-2.6.6-0ubuntu0.14.04.1)
OpenJDK 64-Bit Server VM (build 24.95-b01, mixed mode)

Well, I built it using java7 from the releases tag and I am ok for now. I can create a PR for upgrading the install doc to mention java 8; it currently says OpenJDK 7 or higher. However, I would like to know if that is really required; can we not use String.join and save a version change for current users?

[steveniemitz]

It's not really required, using that method was an oversight. I already have an open pull request #233 that removes the need for it.

[steveniemitz]

This should be fixed now, want to give master another try?

[krish7919]

This works now with openJDL 7. :+1: