Fix --bind-address problem identified by issue 197

mesos / kafka

Apache Kafka on Apache Mesos

Apache License 2.0

414 stars 140 forks source link

Fix --bind-address problem identified by issue 197 #259

Closed yu2003w closed 7 years ago

yu2003w commented 7 years ago

Since kafka 0.9.0, option "listeners" has been introduced. However, it doesn't compatible with '--bind-address" which is an parameter of kafka mesos scheduler. To fix the problem, if "--bind-address" is specified, "host" of "listeners" should be set as "offer.getHostname". This fix was tested in development environment.

steveniemitz commented 7 years ago

Cool, I'd help merge this if I could but unfortunately the only people with write access to this repo disappeared. :(

yu2003w commented 7 years ago

@steveniemitz I talked with some guys from mesosphere. It seemed that the original author did not want to maintain this project anymore. If so, it's really a pity. Thanks very much for your review.

steveniemitz commented 7 years ago

This was merged in ed0ff0732990c2fc4a7f3ef192b15a34ca2f12b3