search

mesqueeb / vuex-easy-firestore

Easy coupling of firestore and a vuex module. 2-way sync with 0 boilerplate!
https://mesqueeb.github.io/vuex-easy-firestore
MIT License
233 stars 28 forks source link

fix: TypeError When Deleting Nested Data #402

Open zabakala opened 1 year ago

zabakala commented 1 year ago

Hi. I just ran into an issue when trying to delete nested data.

vuex1 vuex2

Properly resolving the import from Firestore resolved the issue. Thx beforehand for taking a look at this PR.

mesqueeb commented 1 year ago

This is an issue when there are two different versions of firebase I believe.

mesqueeb commented 1 year ago

This is an issue when there are two different versions of firebase I believe.

zabakala commented 1 year ago

Yop, it could be. It is in line with the repo´s package.json, i.e. "firebase": "^9.0.0". In this particular erroneous case of mine, the imported one is firebase": "9.9.2", i.e. not 10 or onwards. But the imported /compat variant is to ensure correct functionality.

zabakala commented 1 year ago

@mesqueeb Hi. Is there a probability of merging in either this one or anything else leading to the resolution of this reported issue? We have, for the time being, resorted to using a forked version of the repo with the fix included, but we would like to switch back to the original one.

mesqueeb commented 1 year ago

@zabakala I'm just not sure this is the correct fix. I'm dependency injecting the firebase instance IIRC. So there must be something going wrong somewhere else perhaps. I will try and have a look this week.