search

meta-llama / llama-models

Utilities intended for use with Llama models.
Other
4.96k stars 853 forks source link

Fix path resolving #104

Closed danielhanchen closed 3 months ago

danielhanchen commented 3 months ago

Some fixes to join strings for file paths

facebook-github-bot commented 3 months ago

Hi @danielhanchen!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

danielhanchen commented 3 months ago

Oh whoops I'll do the CLA thingo

danielhanchen commented 3 months ago

Ok just did the CLA!

facebook-github-bot commented 3 months ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

ashwinb commented 3 months ago

I don't think this is needed. THIS_DIR is of type pathlib.Path which overloads the "/" operator correctly. Can you show the precise failure?

danielhanchen commented 3 months ago

Oh actually - it seems like I overrided THIS_DIR with the actual directory in a Colab, and did not use pathlib.Path

ashwinb commented 3 months ago

Ok cool, closing this then.