search

metafizzy / flickity-fade

Fade between Flickity slides
62 stars 18 forks source link

Fix fading problem when only two slides #16

Open naokazuterada opened 3 years ago

naokazuterada commented 3 years ago

Thanks for the great plugin.

I found a small problem and will send you a report and suggested fix.

Reproduction

When there are two slides, when returning from the second slide to the first, the first slide is displayed instantly instead of fading (this problem did not seem to be reproduced when there were three or more slides).

Solution

I haven't investigated it too closely, but I think it is caused by the negative value of "progress".

If there is a better fix, it's OK not to merge.

gavin310 commented 1 year ago

@desandro This fix works great. Why not merge it?