:seedling: bump golang to 1.23.3 and golangci-lint to 1.60.3

metal3-io / cluster-api-provider-metal3

Metal³ integration with https://github.com/kubernetes-sigs/cluster-api

Apache License 2.0

212 stars 96 forks source link

:seedling: bump golang to 1.23.3 and golangci-lint to 1.60.3 #2087

Closed tuminoid closed 1 week ago

tuminoid commented 2 weeks ago

[x] Bump Golang to 1.23.3.
[x] Bump Golangci-lint to 1.60.3 to support Go 1.23.
1. Get rid of deprecated golangci-lint configs
2. add timeout to the action, otherwise it'll be timed out in 1 minute. 15 minutes is consistent with "make lint" timeout.
[x] Fix issues coming via new golangci-lint
1. Fix new linter errors by removing the return value which is always nil (unparam linter), and thus meaningless.
2. "exportloopref" is not needed from Go 1.22 onwards, replaced by "copyloopvar" in golangci-lint 1.60.2.
3. Ambiguous string warnings in Wrapf fixed.
4. Fix gosec issue about int32 overflow

Fixes: #2047

tuminoid commented 2 weeks ago

/test metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main

tuminoid commented 2 weeks ago

/test metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main

tuminoid commented 2 weeks ago

/cc @kashifest @adilGhaffarDev @lentzi90

tuminoid commented 2 weeks ago

Our local "make lint" and "make test" don't definitely run same stuff as the linter action, this PR was locally clean long time ago, but PR checks came up with issues not seen locally. Quite sad setup ...

tuminoid commented 2 weeks ago

Manual cherry-pick for 1.8 here: https://github.com/metal3-io/cluster-api-provider-metal3/pull/2099

Release 1.7 does not need one as it is going out of support along with 1.9 and Golang 1.22 is supported for the rest of its life.

tuminoid commented 1 week ago

/retest

metal3-io-bot commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lentzi90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/metal3-io/cluster-api-provider-metal3/blob/main/OWNERS)~~ [lentzi90] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

tuminoid commented 1 week ago

/retest

tuminoid commented 1 week ago

If this aborts again due to timeout, I'll override it, as the log is filled with unrelated Jenkins agent issues and network flakes. Ubuntu has passed long time ago.

tuminoid commented 1 week ago

/override metal3-centos-e2e-integration-test-main

metal3-io-bot commented 1 week ago

@tuminoid: Overrode contexts on behalf of tuminoid: metal3-centos-e2e-integration-test-main

In response to [this](https://github.com/metal3-io/cluster-api-provider-metal3/pull/2087#issuecomment-2482981895): >/override metal3-centos-e2e-integration-test-main Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.