search

metal3-io / ironic-client

Ironic Client Utilities (for debugging via Ironic APIs)
Apache License 2.0
3 stars 10 forks source link

Transition away from openstackclient #4

Closed dtantsur closed 3 years ago

dtantsur commented 3 years ago

We have /usr/bin/baremetal since a while, let's stop using openstackclient. It is broken with http_basic auth anyway.

dtantsur commented 3 years ago 
$ podman run ironic-client node list
The Bare Metal API endpoint cannot be detected and was not provided explicitly.
* Use --os-endpoint for standalone ironic.
* Use --os-auth-url and credentials for authentication.
* Use --os-cloud to load configuration from clouds.yaml
* See `/usr/bin/baremetal --help` for more details

Works as expected (I don't have a cloud here).

hardys commented 3 years ago

lgtm - we may also need to update metal3-dev-env ref https://github.com/metal3-io/metal3-dev-env/blob/master/02_configure_host.sh#L216..L222

And potentially update https://github.com/openshift-metal3/dev-scripts/blob/master/02_configure_host.sh#L230..L234 if we want to move the wrapper script naming away from openstackclient.sh

metal3-io-bot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur, iurygregory

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/metal3-io/ironic-client/blob/master/OWNERS)~~ [dtantsur] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
elfosardo commented 3 years ago

/lgtm

metal3-io-bot commented 3 years ago

@elfosardo: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to [this](https://github.com/metal3-io/ironic-client/pull/4#issuecomment-801193276): >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
dtantsur commented 3 years ago

Oo

You should be in reviewers really, adding in https://github.com/metal3-io/ironic-client/pull/5

hardys commented 3 years ago

This was discussed in the weekly community meeting for visibility, and it doesn't sound like it'll impact any existing users.

/lgtm