:bug: Pin ironic source

metal3-io / ironic-image

Container image to run OpenStack Ironic as part of Metal³

Apache License 2.0

57 stars 118 forks source link

:bug: Pin ironic source #559

Closed Rozzii closed 2 months ago

Rozzii commented 2 months ago

Workaround to unblock the CI.

This commit:

Pins the Ironic source to a WIP upstream gerrit change that resolves a regression introduced by a recent change.

Rozzii commented 2 months ago

/test metal3-centos-e2e-integration-test-main /test metal3-ubuntu-e2e-integration-test-main

Rozzii commented 2 months ago

/test metal3-centos-e2e-integration-test-main /test metal3-ubuntu-e2e-integration-test-main

tuminoid commented 2 months ago

/retest Flake

dtantsur commented 2 months ago

/approve

Let's remember to revert it as soon as possible.

metal3-io-bot commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/metal3-io/ironic-image/blob/main/OWNERS)~~ [dtantsur] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

tuminoid commented 2 months ago

/retest Network flake

tuminoid commented 2 months ago

Centos has passed the inspection, so this is a good fix :+1:

tuminoid commented 2 months ago

/override metal3-ubuntu-e2e-integration-test-main Ubuntu is network flaking out, so I'm overriding so we can get the fix in.

metal3-io-bot commented 2 months ago

@tuminoid: Overrode contexts on behalf of tuminoid: metal3-ubuntu-e2e-integration-test-main

In response to [this](https://github.com/metal3-io/ironic-image/pull/559#issuecomment-2343895990): >/override metal3-ubuntu-e2e-integration-test-main >Ubuntu is network flaking out, so I'm overriding so we can get the fix in. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.

tuminoid commented 2 months ago

Once this merges, I will create revert PR to remind us to get rid of this, when the patch lands on upstream Ironic.