search

metal3-io / ironic-image

Container image to run OpenStack Ironic as part of Metal³
Apache License 2.0
57 stars 118 forks source link

🐛SQLite: fix Ironic container restarting issue #563

Closed blallau closed 2 months ago

blallau commented 2 months ago

In case of SQLite implementation Ironic container fails to restart. create_schema will be called only when required.

fixes #562

metal3-io-bot commented 2 months ago

Hi @blallau. Thanks for your PR.

I'm waiting for a metal3-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
tuminoid commented 2 months ago

/ok-to-test

Please sign-off commit as well.

Rozzii commented 2 months ago

/test metal3-centos-e2e-integration-test-main /test metal3-ubuntu-e2e-integration-test-main /lgtm

tuminoid commented 2 months ago

/cc @dtantsur @elfosardo

elfosardo commented 2 months ago

/approve

metal3-io-bot commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elfosardo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/metal3-io/ironic-image/blob/main/OWNERS)~~ [elfosardo] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
tuminoid commented 2 months ago

Should we cherry-pick this to release branches?

elfosardo commented 2 months ago

@tuminoid yes, up to release-24.0 I guess

tuminoid commented 2 months ago

/cherry-pick release-26.0

metal3-io-bot commented 2 months ago

@tuminoid: new pull request created: #564

In response to [this](https://github.com/metal3-io/ironic-image/pull/563#issuecomment-2363238752): >/cherry-pick release-26.0 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
tuminoid commented 2 months ago

/cherry-pick release-25.0

metal3-io-bot commented 2 months ago

@tuminoid: new pull request created: #565

In response to [this](https://github.com/metal3-io/ironic-image/pull/563#issuecomment-2363240291): >/cherry-pick release-25.0 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
tuminoid commented 2 months ago

/cherry-pick release-24.1

tuminoid commented 2 months ago

/cherry-pick release-24.0

metal3-io-bot commented 2 months ago

@tuminoid: new pull request created: #566

In response to [this](https://github.com/metal3-io/ironic-image/pull/563#issuecomment-2363241630): >/cherry-pick release-24.1 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
metal3-io-bot commented 2 months ago

@tuminoid: new pull request created: #567

In response to [this](https://github.com/metal3-io/ironic-image/pull/563#issuecomment-2363241830): >/cherry-pick release-24.0 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
tuminoid commented 2 months ago

@tuminoid yes, up to release-24.0 I guess

Done, please approve.