search

metal3-io / ironic-image

Container image to run OpenStack Ironic as part of Metal³
Apache License 2.0
57 stars 118 forks source link

:bug: Pin setuptools and pin upper-constraints #569

Closed elfosardo closed 1 month ago

elfosardo commented 1 month ago

Usually the setuptools installed by the system is stable but a bit too old compared to the packages we use for ironic, so pinning a more recent version helps avoiding errors and incompatibilities.

Also pin upper-constraints since we forgot!

elfosardo commented 1 month ago

/test metal3-centos-e2e-integration-test-release-1-6 metal3-ubuntu-e2e-integration-test-release-1-6

elfosardo commented 1 month ago

/cc @dtantsur

tuminoid commented 1 month ago

Oh we had forgotten to pin the requirements, ouch :)

elfosardo commented 1 month ago

/test metal3-centos-e2e-integration-test-release-1-6 metal3-ubuntu-e2e-integration-test-release-1-6

elfosardo commented 1 month ago

@dtantsur can you please have a look?

dtantsur commented 1 month ago

/approve

metal3-io-bot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/metal3-io/ironic-image/blob/release-24.0/OWNERS)~~ [dtantsur] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment