search

metal3-io / metal3-dev-env

Metal³ Development Environment
Apache License 2.0
113 stars 118 forks source link

Echo error string in stderr instead of stdout #1374

Closed kashifest closed 8 months ago

kashifest commented 8 months ago

Function get_latest_release() is called as a subshell and since the echo is in stdout in case an error has occurred, this error string is exported wrongly as the release versions in variables.This in turn fools the empty check and causes the lib/releases.sh not to error out. The test moves on and fails elsewhere with a confusing error output.

kashifest commented 8 months ago

/test-ubuntu-e2e-integration-main /test-centos-integration-release-1-6

kashifest commented 8 months ago

As you can see, we are lucky to hit the issue right away and now the lib/releases.sh is failing right away without moving forward https://jenkins.nordix.org/job/metal3_metal3_dev_env_main_e2e_integration_test_ubuntu/318/ https://jenkins.nordix.org/job/metal3_metal3_dev_env_release-1-6_integration_test_centos/72/

kashifest commented 8 months ago

/test-ubuntu-e2e-integration-main /test-centos-integration-release-1-6

metal3-io-bot commented 8 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: smoshiur1237

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/metal3-io/metal3-dev-env/blob/main/OWNERS)~~ [smoshiur1237] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment