search

metal3-io / metal3-dev-env

Metal³ Development Environment
Apache License 2.0
113 stars 118 forks source link

Applying BMH Should Be Part of the Test Setup #1383

Closed mboukhalfa closed 1 month ago

mboukhalfa commented 7 months ago

Currently, in the Metal³ dev-env, BMHs are applied in the metal3 namespace and then inspected during the make process. However, when reusing CAPI tests such as md_remediations.go, which utilizes random namespace we are applying bmh in that namespace through the hook PostNamespaceCreated, it becomes evident that applying BMHs in the metal3 namespace and then deleting them in e2e tests, only to recreate them in a different namespace, is not the most efficient approach.

To streamline the testing process and ensure alignment with evolving testing methodologies, it's recommended to update dev-env so that BMHs are applied as part of the test setup, directly in the appropriate namespace, rather than being applied by default in the metal3 namespace as part of the make process.

Proposed Solution:

  1. Remove the step of applying BMHs in the verify.sh script and inspecting them.
  2. Update the Ansible tests under /tests to apply the BMHs from a separate file before running the tests.
  3. Eliminate the part where BMHs are deleted from the metal3 namespace and instead include applying them as part of every e2e test.
  4. Remove the BMH file bmhosts_crs.yaml since it will no longer be needed (#1353)

Reference: https://github.com/metal3-io/cluster-api-provider-metal3/issues/1080

Rozzii commented 7 months ago

/triage accepted I am willing to accept it but please whoever fixes this make it so that the BMHs can be deployed without running the tests and deploying CPI and CAPM3, this would be a big help for those who are developing only BMO functionality without higher level Metal3 components.

metal3-io-bot commented 4 months ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues will close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle stale

Rozzii commented 4 months ago

/remove-lifecycle stale

metal3-io-bot commented 1 month ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues will close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle stale

mboukhalfa commented 1 month ago

@adilGhaffarDev I think we can close this or until we make it for all tests ?

Rozzii commented 1 month ago

/close According to 2024-10-23 Community Meeting decision.

metal3-io-bot commented 1 month ago

@Rozzii: Closing this issue.

In response to [this](https://github.com/metal3-io/metal3-dev-env/issues/1383#issuecomment-2432392650): >/close >According to 2024-10-23 Community Meeting decision. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.