search

metal3-io / metal3-dev-env

Metal³ Development Environment
Apache License 2.0
113 stars 118 forks source link

Use 'virt' for latest #1442

Closed sgoveas closed 3 months ago

sgoveas commented 4 months ago

The versioned machine types can disappear in future versions of libvirt, and the one in use 'virt-rhel8.2.0' is no longer available. "virt" means "the latest version"

"msg": "libvirtError: unsupported configuration: Emulator
'/usr/libexec/qemu-kvm' does not support machine type 'virt-rhel8.2.0'"

Signed-off-by: Steeve Goveas sgoveas@redhat.com

metal3-io-bot commented 4 months ago

Hi @sgoveas. Thanks for your PR.

I'm waiting for a metal3-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
mboukhalfa commented 4 months ago

No description provided.

I would like to get some description ? Are you experimenting or there is some need for this changes ? I do have clear idea about the difference between the two definition

dtantsur commented 4 months ago

Are you experimenting or there is some need for this changes ? I do have clear idea about the difference between the two definition

I expect the final version of the PR to contain an explanation, but tl;dr the versioned machine types can disappear in future versions of libvirt, and apparently this one is no longer available. Just "virt" means "the latest version".

Sunnatillo commented 3 months ago

/ok-to-test

Sunnatillo commented 3 months ago

/test metal3-centos-e2e-integration-test-release-1-7

elfosardo commented 3 months ago

/test metal3-dev-env-integration-test-ubuntu-main

elfosardo commented 3 months ago

/test metal3-dev-env-integration-test-ubuntu-main

elfosardo commented 3 months ago

/approve

metal3-io-bot commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elfosardo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/metal3-io/metal3-dev-env/blob/main/OWNERS)~~ [elfosardo] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
elfosardo commented 3 months ago

/test metal3-centos-e2e-integration-test-release-1-7