search

metal3-io / metal3-dev-env

Metal³ Development Environment
Apache License 2.0
113 stars 118 forks source link

🌱 Fixing CAPM3RELEASE for main branch #1452

Closed adilGhaffarDev closed 2 months ago

adilGhaffarDev commented 2 months ago

Fixing CAPM3RELEASE to point to main for main branch tests

metal3-io-bot commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tuminoid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/metal3-io/metal3-dev-env/blob/main/OWNERS)~~ [tuminoid] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
tuminoid commented 2 months ago

/test metal3-centos-e2e-integration-test-release-1-8

tuminoid commented 2 months ago

/override metal3-centos-e2e-integration-test-release-1-8 just ran it to fix branch protection

metal3-io-bot commented 2 months ago

@tuminoid: Overrode contexts on behalf of tuminoid: metal3-centos-e2e-integration-test-release-1-8

In response to [this](https://github.com/metal3-io/metal3-dev-env/pull/1452#issuecomment-2320296582): >/override metal3-centos-e2e-integration-test-release-1-8 >just ran it to fix branch protection Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
tuminoid commented 2 months ago

/hold There is discussion about the 1.9.99 in CAPM3 PR.

adilGhaffarDev commented 2 months ago

once this: https://github.com/metal3-io/cluster-api-provider-metal3/pull/1938 merged metal3-centos-e2e-integration-test-release-1-8 test will pass.

tuminoid commented 2 months ago

/override metal3-centos-e2e-integration-test-release-1-8 metal3-dev-env-integration-test-ubuntu-main /unhold This goes in first and then we can merge capm3 PRs.

metal3-io-bot commented 2 months ago

@tuminoid: Overrode contexts on behalf of tuminoid: metal3-centos-e2e-integration-test-release-1-8, metal3-dev-env-integration-test-ubuntu-main

In response to [this](https://github.com/metal3-io/metal3-dev-env/pull/1452#issuecomment-2320483266): >/override metal3-centos-e2e-integration-test-release-1-8 metal3-dev-env-integration-test-ubuntu-main >/unhold >This goes in first and then we can merge capm3 PRs. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.