metal3-io / metal3-dev-env

Metal³ Development Environment
Apache License 2.0
113 stars 118 forks source link

:warning: Change the way IPAM is deployed with CAPM3 and Test changes made in IPAM and CAPM3 together #1459

Open peppi-lotta opened 2 months ago

peppi-lotta commented 2 months ago

When making IPAm into a provider for CAPI, I needed to change the namespace where IPAM is living and how IPAM is deployed. This PR is made to match those changes in IPAM. There are also changes to CAPM3 These are the related PRs:

These new changes are dependent from each other so the test are not passing in the PRs. This PR changes the way IPAM is deployed with CAMP3 and tests the 2 dependent PR branches together.

metal3-io-bot commented 2 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign elfosardo for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/metal3-io/metal3-dev-env/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
peppi-lotta commented 2 months ago

/test metal3-dev-env-integration-test-ubuntu-main

mquhuy commented 2 months ago

/test metal3-dev-env-integration-test-ubuntu-main

peppi-lotta commented 1 month ago

/test metal3-dev-env-integration-test-ubuntu-main

peppi-lotta commented 1 month ago

/test metal3-dev-env-integration-test-ubuntu-main

peppi-lotta commented 1 month ago

/test metal3-dev-env-integration-test-ubuntu-main

peppi-lotta commented 1 month ago

/test metal3-dev-env-integration-test-ubuntu-main

peppi-lotta commented 1 month ago

/test metal3-dev-env-integration-test-ubuntu-main

peppi-lotta commented 1 month ago

/test metal3-dev-env-integration-test-ubuntu-main

peppi-lotta commented 1 month ago

/test metal3-dev-env-integration-test-ubuntu-main

peppi-lotta commented 1 month ago

/test metal3-dev-env-integration-test-ubuntu-main

peppi-lotta commented 1 month ago

/test metal3-dev-env-integration-test-ubuntu-main

peppi-lotta commented 1 month ago

/test metal3-dev-env-integration-test-ubuntu-main

peppi-lotta commented 1 month ago

/test metal3-dev-env-integration-test-ubuntu-main

peppi-lotta commented 1 month ago

/test metal3-dev-env-integration-test-ubuntu-main

peppi-lotta commented 1 month ago

/test metal3-centos-e2e-integration-test-release-1-8

peppi-lotta commented 1 month ago

/test ?

metal3-io-bot commented 1 month ago

@peppi-lotta: The following commands are available to trigger required jobs:

The following commands are available to trigger optional jobs:

Use /test all to run the following jobs that were automatically triggered:

In response to [this](https://github.com/metal3-io/metal3-dev-env/pull/1459#issuecomment-2431803946): >/test ? > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
peppi-lotta commented 1 month ago

/test metal3-centos-e2e-integration-test-release-1-8

peppi-lotta commented 3 weeks ago

/test metal3-dev-env-integration-test-ubuntu-main /test metal3-centos-e2e-integration-test-release-1-8

peppi-lotta commented 3 weeks ago

/test metal3-ubuntu-e2e-integration-test-main /test metal3-centos-e2e-integration-test-main

peppi-lotta commented 3 weeks ago

/test metal3-centos-e2e-integration-test-release-1-8

peppi-lotta commented 3 weeks ago

/test metal3-dev-env-integration-test-ubuntu-main /test metal3-centos-e2e-integration-test-release-1-8

peppi-lotta commented 3 weeks ago

/test metal3-centos-e2e-integration-test-release-1-8

peppi-lotta commented 3 weeks ago

/test ?

metal3-io-bot commented 3 weeks ago

@peppi-lotta: The following commands are available to trigger required jobs:

The following commands are available to trigger optional jobs:

Use /test all to run the following jobs that were automatically triggered:

In response to [this](https://github.com/metal3-io/metal3-dev-env/pull/1459#issuecomment-2451704005): >/test ? > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
peppi-lotta commented 3 weeks ago

/test /test metal3-centos-e2e-integration-test-main /test metal3-dev-env-integration-test-ubuntu-main

peppi-lotta commented 2 weeks ago

/test metal3-dev-env-integration-test-ubuntu-main /test metal3-dev-env-integration-test-centos-main

metal3-io-bot commented 2 weeks ago

@peppi-lotta: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
metal3-ubuntu-e2e-integration-test-main e12068084398bbda697a482afaf206faff23fedd link false /test metal3-ubuntu-e2e-integration-test-main
metal3-centos-e2e-integration-test-release-1-8 31fb99628c7a15aa7f4f80320967878e421cd44d link true /test metal3-centos-e2e-integration-test-release-1-8
metal3-centos-e2e-integration-test-main 1f1661056681e04592fe7ab08ad7e2f55d17e1d7 link false /test metal3-centos-e2e-integration-test-main
Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
peppi-lotta commented 2 weeks ago

/test metal3-dev-env-integration-test-centos-main