search

metanorma / pubid-iso

Implementation of ISO pubid
BSD 2-Clause "Simplified" License
1 stars 0 forks source link

URGENT! PRF stage isn't rendered #257

Closed andrew2net closed 6 months ago

andrew2net commented 7 months ago 
Pubid::Iso::Identifier.parse('ISO 7029:2017/PRF Amd 1').to_s
=> "ISO 7029:2017/Amd 1"
mico commented 7 months ago 
Pubid::Iso::Identifier.parse('ISO 7029:2017/PRF Amd 1').to_s
=> "ISO 7029:2017/Amd 1"

"PRF" stage is not rendered by default, see https://github.com/metanorma/pubid-iso/issues/106

andrew2net commented 7 months ago

"PRF" stage is not rendered by default, see #106

@mico what is the way to render PRF?

BTW it seems the examples in the doc are incorrect. The pubid.to_s(:ref_num_short) doesn't work. Shouldn't it be pubid.to_s(format: :ref_num_short)?

ronaldtse commented 7 months ago

I think it's pubid.to_s(with_prf: true)?

andrew2net commented 7 months ago

I think it's pubid.to_s(with_prf: true)?

@ronaldtse there is no such option. @mico explain how to render "PRF" please

mico commented 7 months ago

I think it's pubid.to_s(with_prf: true)?

@ronaldtse there is no such option. @mico explain how to render "PRF" please

@andrew2net https://github.com/metanorma/pubid-iso/blob/ed3c5674ba757d0d296df487ba856b86f7c029ec/spec/pubid_iso/identifier/create_new_identifier_spec.rb#L120-L124

andrew2net commented 7 months ago

@mico why it doesn't work for me?

> Pubid::Iso::Identifier.parse('ISO 7029:2017/PRF Amd 1').to_s with_prf: true
 => "ISO 7029:2017/Amd 1"

I use supplement-empty-publisher branch.

ronaldtse commented 7 months ago

Is it because Supplements don't support PRF yet?