search

metanorma / pubid-iso

Implementation of ISO pubid
BSD 2-Clause "Simplified" License
1 stars 0 forks source link

Create integration tests with relaton-iso #260

Closed andrew2net closed 6 months ago

andrew2net commented 7 months ago

We need to be sure that patch version doesn't break Relaton. So we need to create GHA that tests this gem with relaton-iso before release.

mico commented 7 months ago

@CAMOBAP can we test relaton-iso gem before releasing patch? For minor release, we don't need to do this.

CAMOBAP commented 7 months ago

@mico @andrew2net

  1. where this integrated test must be implemented on pubid-isoside or relaton-iso side? or maybe both?
  2. should we implement this approach for other pubid-* and/or relaton-* gems too?
andrew2net commented 7 months ago

@CAMOBAP

  1. The test must be implemented on pubid-iso side. We need to be sure that any new pubid-iso patch version won't break Relaton.
  2. Yes, later we will need to implement this approach for all other pubid-*. At this moment Relaton uses only pubid-iso, so we need to start with it.

The pubid-core has similar dependent-test already. I think there is a chance that pubid-core pass the dependent-tests with pubid-* gems but the Relaton may have issue. So we need to test pubid-core with Relaton too.

CAMOBAP commented 6 months ago

Merged