metanorma / stepmod-utils

Tools for working on the STEPmod repository.
1 stars 0 forks source link

Annotations on EXPRESS should replace `;;` with `;` #197

Closed ronaldtse closed 12 months ago

ronaldtse commented 1 year ago

In Asciidoc, the ;; pattern is considered to be the command for a definition list (https://docs.asciidoctor.org/asciidoc/latest/lists/description/).

These are not actually meant to be such in the annotations.

We should replace ;; with just ; in the EXPRESS annotations.

(*"geometric_model_schema.boolean_result.second_operand"
the second operand to be operated upon by the boolean operation;;
*)
(*"geometry_schema.trimming_preference.parameter"
trimming by parameter value is preferred;;
*)
ronaldtse commented 1 year ago

This issue stems from the XML files.

ronaldtse commented 1 year ago

@TRThurman the problem does exist in both SMRLv9 and develop:

/iso-10303-srl/iso-10303-stepmod-wg12 (SMRLv9 =): gg 'trimming by parameter'
data/resources/geometry_schema/Originaldescriptions.xml:        trimming by parameter value is preferred;;
data/resources/geometry_schema/descriptions.xml:                trimming by parameter value is preferred;;
data/resources/geometry_schema/descriptions2013.xml:    trimming by parameter value is preferred;;
$ gg 'the second operand to be operated'
data/resources/geometric_model_schema/descriptions.xml:         the second operand to be operated upon by the boolean operation;;
/iso-10303-srl/iso-10303-stepmod-wg12 (develop =): gg 'trimming by parameter'
data/resources/geometry_schema/Originaldescriptions.xml:        trimming by parameter value is preferred;;
data/resources/geometry_schema/descriptions.xml:                trimming by parameter value is preferred;;
data/resources/geometry_schema/descriptions2013.xml:    trimming by parameter value is preferred;;
TRThurman commented 1 year ago

Is that the only location? Sent from my iPhone

ronaldtse commented 1 year ago

@TRThurman yes, those are the only two places. Thanks!

TRThurman commented 1 year ago

I noticed that 
 is being injected into mim_lf.xml by the EXPRESS -> XML tool. But I see no rationale for that to occur. Looks like a bug in the EXPRESS->XML tool.

here are a few lines generated by latest eengine tool in --xml function against ap 203 mim_lf.exp from stepdev:

<constant name="deprecated_constructed_data_types" expression="['approved_item',&#10;                                              'certified_item',&#10;                                              'change_request_item',&#10;                                              'contracted_item',&#10;                                              'cc_classified_item',&#10;                                              'date_time_item',&#10;                                              'cc_person_organization_item',&#10;                                              'cc_specified_item',&#10;                                              'start_request_item',&#10;                                              'work_item']">

I will ask Robert Swindells to correct that. I see no need for you folks to do anything heroic here to try to work around this garbage.