search

metaplex-foundation / amman

A modern mandatory toolbelt to help test solana SDK libraries and apps on a locally running validator.
https://metaplex-foundation.github.io/amman/docs/
Apache License 2.0
72 stars 17 forks source link

fix build fail issue on amman/src/cli/amman.ts caused by function cal… #65

Open karlvlam opened 1 year ago

karlvlam commented 1 year ago

Here's the fix for the issue when we run yarn build. Fixing this would help the newbies to test easily. @thlorenz 

$ yarn build
yarn run v1.22.19
$ yarn build:client && yarn build:amman
$ rimraf amman-client/dist && tsc -p amman-client/tsconfig.json
$ rimraf amman/dist && tsc -p amman/tsconfig.json
amman/src/cli/amman.ts:248:26 - error TS2345: Argument of type 'unknown' is not assignable to parameter of type 'string'.

248         assertCommitment(commitment)
                             ~~~~~~~~~~

amman/src/cli/amman.ts:253:11 - error TS2345: Argument of type '{}' is not assignable to parameter of type 'string'.

253           label!,
              ~~~~~~

amman/src/cli/amman.ts:299:45 - error TS2345: Argument of type 'unknown' is not assignable to parameter of type 'boolean'.

299         await handleAccountCommand(address, includeTx, save)
                                                ~~~~~~~~~

amman/src/cli/amman.ts:331:11 - error TS2322: Type '{}' is not assignable to type 'string | string[]'.

331       let labels: string | string[] = args.label ?? []
              ~~~~~~

amman/src/cli/amman.ts:346:11 - error TS2345: Argument of type 'unknown' is not assignable to parameter of type 'boolean'.

346           txOnly,
              ~~~~~~

Found 5 errors in the same file, starting at: amman/src/cli/amman.ts:248

error Command failed with exit code 2.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
error Command failed with exit code 2.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.