search

metaplex-foundation / js-deprecated

Deprecated Metaplex JavaScript SDK
https://metaplex-foundation.github.io/js/
MIT License
128 stars 77 forks source link

update mpl-token-metadata dependency #165

Closed DanielFLopez closed 2 years ago

DanielFLopez commented 2 years ago

update mpl-token-metadata dependency

yamijuan commented 2 years ago

hey @aheckmann We want to update this dependency since other projects, like Solana's explorer, use this SDK to read that library. This will allow the explorer to display the new token metadata standard in their metadata tab.

aheckmann commented 2 years ago

CI fails with The lockfile would have been modified by this install, which is explicitly forbidden. We ran into this issue separately, yesterday. What worked for us was removing the current yarn.lock and reinstalling. Another action which may help is removing unrelated yarn.lock file in the home ~ directory and rerunning the above step. I'll open a new PR and see if this resolves it. (not sure if this is a yarn 3 issue or not yet)

aheckmann commented 2 years ago

Closing this one in favor of #168 which has passing CI