search

metosin / spec-tools

Clojure(Script) tools for clojure.spec
Eclipse Public License 2.0
593 stars 94 forks source link

Disable *transformer* variable inside a transformer call #247

Closed wandersoncferreira closed 3 years ago

wandersoncferreira commented 4 years ago

Idea about how to solve #240 . The solution here is to disable the *transformer* dynamic variable when a transform function is called. I think this is a reasonable thing to do to avoid StackOverFlow scenarios.

There is more details in #240 thread.

Thanks

miikka commented 3 years ago

@wandersoncferreira I merged #248 and took a look at this. The change looks good, so if you update ih to work with the latest master, I'd be happy to merge it. Thanks again for your work!

wandersoncferreira commented 3 years ago

Great @miikka , thanks for taking the time to look at these PRs. I made the adjustments

codecov-io commented 3 years ago

Codecov Report

Merging #247 (1cefe6b) into master (b6bfa14) will increase coverage by 0.01%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #247      +/-   ##
==========================================
+ Coverage   87.99%   88.01%   +0.01%     
==========================================
  Files          16       16              
  Lines        2049     2052       +3     
  Branches      183      183              
==========================================
+ Hits         1803     1806       +3     
  Misses         63       63              
  Partials      183      183
Impacted Files Coverage Δ
src/spec_tools/core.cljc 94.42% <100.00%> (+0.04%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b6bfa14...1cefe6b. Read the comment docs.