search

metricfu / metric_fu

A fist full of code metrics
http://metricfu.github.com/metric_fu
MIT License
624 stars 96 forks source link

Remove specific versions for guard dependencies #310

Closed etagwerker closed 4 years ago

etagwerker commented 4 years ago

Hey @bf4,

This fixes #309. It is a commit extracted from #306,

Please check it out.

Thanks!

bf4 commented 4 years ago

I mean, the PR description is wrong. The PR diff I see removes guard altogethr

etagwerker commented 4 years ago

@bf4 To be honest, I don't know why those dependencies are being installed in Travis CI or Appveyor. They are development dependencies meant for maintainers and contributors to use them, right?

Either way, I changed the title of the PR to better represent the changes in this PR. It fixes the issue I saw when trying to initially setup my dev environment with this gem.

I think it would be best to not install the guard group in Appveyor and Travis CI as it introduces another thing that can fail in those environments and it is not really needed there.

The Travis CI will continue to fail until #308 is merged. 🤷‍♂

bf4 commented 4 years ago

they shouldn't be installed on CI. I agree.

in the travis.yml we have

  - bundle config --local without local_development yard guard

I guess that's missing from appveyor

etagwerker commented 4 years ago

@bf4 There are many things wrong which are causing Appveyor to fail. The one you mentioned is one of them. I created #312 to keep track of that issue and patch.

etagwerker commented 4 years ago

@bf4 What do you suggest I do with this PR?

bronzdoc commented 4 years ago

Going to merge this since this dev dependencies should not be installed in CI and would help us keep moving forward setting a dev environment