CRAN has come up with some methods where the signature does not match the generic. This has been there for a long time and I guess R-devel changed a bit to detect this; it isn't there in R-release or R-devel up to a couple of days ago.
@kyleam - I'm not worried about the compile() method. But I really want to be able to have an as_tibble() method for the simulation output class. I had the signature right at some point but the generic changed and that caused the problems.
I'm heading toward just getting the methods matched up with the generics and sending that back. That seemed to fix the issue when testing R-devel from yesterday. Wondering about your thoughts on safe / sustainable approach going forward?
Results
Dear maintainer,
Please see the problems shown on
<https://cran.r-project.org/web/checks/check_results_mrgsolve.html>.
Please correct before 2023-03-22 to safely retain your package on CRAN.
Best,
-k
I've only been able to reproduce on (very) recent R-devel.
R CMD check mrgsolve_1.0.8.tar.gz
* using log directory ‘/Users/kyleb/git/m4solve/mrgsolve.Rcheck’
* using R Under development (unstable) (2023-03-07 r83950)
* using platform: aarch64-apple-darwin20 (64-bit)
* R was compiled by
Apple clang version 13.0.0 (clang-1300.0.29.3)
GNU Fortran (GCC) 12.0.1 20220312 (experimental)
* running under: macOS Ventura 13.2
...
* checking dependencies in R code ... OK
* checking S3 generic/method consistency ... WARNING
compiled:
function(x, ...)
compiled.mrgmod:
function(x, status)
as_tibble:
function(x, ..., .rows, .name_repair, rownames)
as_tibble.mrgsims:
function(.data_, ...)
See section ‘Generic functions and methods’ in the ‘Writing R
Extensions’ manual.
* checking replacement functions ... OK
* checking foreign function calls ... OK
The changes in this PR seem to fix the issue
R CMD check mrgsolve_1.0.8.9001.tar.gz
* using log directory ‘/Users/kyleb/git/m4solve/mrgsolve.Rcheck’
* using R Under development (unstable) (2023-03-07 r83950)
* using platform: aarch64-apple-darwin20 (64-bit)
* R was compiled by
Apple clang version 13.0.0 (clang-1300.0.29.3)
GNU Fortran (GCC) 12.0.1 20220312 (experimental)
* running under: macOS Ventura 13.2
...
* checking dependencies in R code ... OK
* checking S3 generic/method consistency ... OK
*
Summary
CRAN has come up with some methods where the signature does not match the generic. This has been there for a long time and I guess R-devel changed a bit to detect this; it isn't there in R-release or R-devel up to a couple of days ago.
@kyleam - I'm not worried about the
compile()
method. But I really want to be able to have anas_tibble()
method for the simulation output class. I had the signature right at some point but the generic changed and that caused the problems.I'm heading toward just getting the methods matched up with the generics and sending that back. That seemed to fix the issue when testing R-devel from yesterday. Wondering about your thoughts on safe / sustainable approach going forward?
Results
https://cran.r-project.org/web/checks/check_results_mrgsolve.html
Tests
Reproduce check issue on
1.0.8
I've only been able to reproduce on (very) recent R-devel.
The changes in this PR seem to fix the issue