search

metrumresearchgroup / pmtables

TeX tables for pharmacometrics.
https://metrumresearchgroup.github.io/pmt-book
11 stars 1 forks source link

is_str_regex: account for stringr 1.5.0 class change #302

Closed kyleam closed 1 year ago

kyleam commented 1 year ago

The class of pattern modifiers has changed with stringr's 2895a6b (Use stringr_ class prefixes for pattern modifiers, 2022-01-18), part of the v1.5.0 release.

This popped up in MPN's check failures. With this patch, checks pass with either stringr 1.5.0 and 1.4.1.

@kylebaron It seemed easy enough to stay backward compatible here, but let me know if you would instead prefer to just bump the stringr version constraint in DESCRIPTION.

kylebaron commented 1 year ago

Thanks for fixing this @kyleam; seems easy enough to accommodate both for now.