search

mevblocker / web

https://mevblocker.io
7 stars 1 forks source link

Issues related to the 'Add to Wallet' button #16

Open elena-zh opened 1 year ago

elena-zh commented 1 year ago

  1. Network name is different in the description, and when send a request to the wallet: network name is different Is this OK?

  2. The PRC details are not added to other injected wallets like Coinbase, TallyHo, etc.:

    • I can see 'Successfully added' message, but these wallets are connected only. Each time when I press on the Add to Wallet button, I get success message with no request to add RPC parameters there: In this case, I think, it would be great to add a error message
    • The issue with Coinbase wallet is reproducible even if I open the app in Coinbase mobile integrated browser.
    • When I switch OFF Coinbase browser's extension, the app still tries to add a network there.

  3. Is this OK that we can add RPC details to MM multiple times even if it is already added?

fairlighteth commented 1 year ago
  1. Fixed this on develop As for 2 and 3, perhaps @anxolin can review this