Commiting to refactor-branch

mexili / incogly

Incogly is a video conferencing app aimed to remove any implicit bias in an interview and easing the process of remote collaboration.

https://incogly.mexili.org/

GNU Affero General Public License v3.0

28 stars 30 forks source link

Commiting to refactor-branch #88

Closed ZohebMOPO closed 3 years ago

ZohebMOPO commented 3 years ago

What is the change?

Changed the branch.

What does it fix/add?

1)It gives some space between the input tag and button 2)Added material-ui buttons which handles the state of audio and video respectively 3) The size of the input tag and buttons were give equal size

How was it tested?

Submissions guide:

[ ] Have you made corresponding changes to the documentation?
[ ] Your submission doesn't break any existing feature.
[ ] Have you lint your code locally prior to submission?

Screenshots (if appropriate):

sansyrox commented 3 years ago

Hi @ZohebMOPO , is this up for review?

ZohebMOPO commented 3 years ago

Oh review, I haven't fixed the last thing, and Idk how will I fix it. So yeah half is done.

sansyrox commented 3 years ago

Oh review, I haven't fixed the last thing, and Idk how will I fix it.

That's alright. Can you mention the problems solved in the description of the PR?

ZohebMOPO commented 3 years ago

Yeah I just added

ZohebMOPO commented 3 years ago

Yeah sure. I gave that classname in a hurry.

P.S. I changed those classnames

ZohebMOPO commented 3 years ago

Oh Ok.

ZohebMOPO commented 3 years ago

Sorry, @sansyrox . I really never used those BEM class naming ways. But it was cool knowing something like this.

sansyrox commented 3 years ago

I really never used those BEM class naming ways.

No worries, @ZohebMOPO . I am glad you learnt something new 😄

welcome[bot] commented 3 years ago

Congrats on merging your first pull request! 🎉 All the best for your amazing open source journey ahead 🚀.