Open justinlaughlin opened 3 days ago
https://github.com/mfem/mfem/pull/3598 introduced a new class DGHyperbolicConservationLaws and refactored ex18.cpp and ex18p.cpp.
DGHyperbolicConservationLaws
ex18.cpp
ex18p.cpp
The new implementation leads to ex18.py failing; the solutions are very similar but different enough to not pass. For example
ex18.py
GetMaxCharSpeed
t=2.0
I'll start branch to wrap the new hyperbolic conservation class and update ex18
https://github.com/mfem/PyMFEM/tree/fix-ex18
justinlaughlin
commented
3 days ago justinlaughlin
commented
3 days ago
https://github.com/mfem/mfem/pull/3598 introduced a new class
DGHyperbolicConservationLawsand refactoredex18.cppandex18p.cpp.The new implementation leads to
ex18.pyfailing; the solutions are very similar but different enough to not pass. For exampleGetMaxCharSpeedresult in 435 time-steps to reacht=2.0rather than 437.I'll start branch to wrap the new hyperbolic conservation class and update ex18