search

mgba-emu / mgba

mGBA Game Boy Advance Emulator
https://mgba.io/
Mozilla Public License 2.0
5.75k stars 794 forks source link

[Wii] Add screen mode options for strect the screen respecting the original GB/GBC/GBA screen dimensions? #2860

Open saulfabregwiivc opened 1 year ago

saulfabregwiivc commented 1 year ago

Hi there :)

This question could be confusing for some but is it possible to add options for this suggestion: A screen mode like "Pixel Accurate" but that can be fit into any screen but respecting the original Game Boy/Game Boy Color/Game Boy Advance screen dimensions, not just 4:3 TVs but also 16:9 TVs.

Current "Pixel-Accurate" setting on 4:3 TVs GB/GBC image GBA image

on 16:9 TVs GB/GBC image GBA image

Taken from mGBA standalone Wii port

What i want you to consider for add a new "Pixel-Accurate (Adapted to TV)" setting on 4:3 TVs GB/GBC image GBA image

on 16:9 TVs GB/GBC image GBA image

These last ones taken from RetroArch Wii port.

Would this be possible of get these screen modes on official mGBA Wii from RA Wii?

Not to mention your port runs pretty well optimized.

endrift commented 1 year ago

Those latter screenshots are very clearly not pixel-accurate--they're aspect ratio full-screen with no filtering, so you have disparate sized pixels. That should be something mGBA already supports, though it's not widescreen-aware afaik

saulfabregwiivc commented 1 year ago

Those latter screenshots are very clearly not pixel-accurate--they're aspect ratio full-screen with no filtering, so you have disparate sized pixels. That should be something mGBA already supports, though it's not widescreen-aware afaik

You're right. These current modes on mGBA Wii are not 16:9 (widescreen) friendly. Would you make widescreen friendly those modes?

saulfabregwiivc commented 1 year ago

As another idea, would you modify a bit the code for the current "Pixel Accurate" option so we can get the objective of only on 4:3 TVs apply the setting like in the screenshots of mGBA Wii, and when on 16:9 TVs, display them like i've posted on the last screenshots? Maybe some code for check Wii's TV settings for give us a widescreen friendly Pixel Accurate option? :)

endrift commented 1 year ago

I don't think you understand what "pixel accurate" means, or perhaps don't understand that wide-screen mode has non-square pixels. You cannot make a pixel accurate mode in widescreen that has the right aspect ratio as a result of the non-square pixels. The only actionable thing here is adding a widescreen aspect fit, but it won't be pixel accurate.

saulfabregwiivc commented 1 year ago

The only actionable thing here is adding a widescreen aspect fit, but it won't be pixel accurate.

Well, if Pixel Accurate isn't possible with what i'm asking, then why not try this thing to mGBA Wii? (Widescreen aspect fit) :)

endrift commented 1 year ago

Yeah that's the action I'm planning on taking for this report.

saulfabregwiivc commented 1 year ago

Sorry for the question but... Any update for adding a 16:9 (widescreen) aspect fit / 16:9 correction to mGBA Wii?

saulfabregwiivc commented 1 year ago

Hey there @endrift, it's me saulfabreg again.

I don't want to bother you but... are you thinking on a possible way for add 16:9 (widescreen) aspect fit / correction to mGBA Wii?

endrift commented 1 year ago

I've scheduled it for 0.11 so I don't lose track