mgba-emu / mgba

mGBA Game Boy Advance Emulator
https://mgba.io/
Mozilla Public License 2.0
5.67k stars 777 forks source link

[Bug] Unable to Multi-Select Pokemon in PC Storage in Pokemon Games [build-2024-07-11-win64-8487-9b598d2fe4c5ae49180fd381c742e5cb8a0973f0] #3257

Closed Priestyle closed 3 months ago

Priestyle commented 3 months ago

I'm unable to multi-select pokemon in pc storage in pokemon games. When you press select, the cursor turns yellow and you can multi-select pokemon to help organize faster. However, when I press A after turning the cursor yellow, it doesn't select multiple pokemon.

CasualPokePlayer commented 3 months ago

Are you actually playing FireRed/LeafGreen or Emerald?

Priestyle commented 3 months ago

Yeah, I actually tested this on Ruby and Emerald. I also tested this on mGBA-0.9.3-win64.

CasualPokePlayer commented 3 months ago

Ruby does not have this feature, it was introduced in FireRed/LeafGreen.

Are you actually holding A to have multiple Pokemon selected before letting go of A to "finalize" the selection.

Priestyle commented 3 months ago

Then why does the cursor change the exact same way in pokemon ruby and sapphire as it does in firered, leafgreen and emerald. What does the yellow cursor do in ruby and sapphire?

CasualPokePlayer commented 3 months ago

It lets you grab a Pokemon without having a menu of options.

Priestyle commented 3 months ago

Hey I just tested this on a real cartridge on my gameboy advance sp and pressing SEL in pc box and holding down A while moving the cursor allows you to select multiple pokemon at once for faster organization. I think this is a bug. Please look into this.

endrift commented 3 months ago

I have no idea what you're talking about. https://github.com/user-attachments/assets/914bf409-f443-4911-9a17-aa74cc3f211d

(This is my original copy of Ruby that I've had for 21 years. Please excuse the SGDQ run on in the background.)

CasualPokePlayer commented 3 months ago

Checking mGBA myself and multi-select works just fine on FireRed/LeafGreen/Emerald. You likely are somehow not actually pressing the buttons correctly in the emulator. Verify you actually are pressing the buttons correctly (I suggest checking whatever you mapped Select and A too, the defaults would be Backspace and X)

endrift commented 3 months ago

I've also confirmed that it works the same in Emerald on hardware and in emulator. I'm pretty convinced that either something is wrong with your controls, you're hitting a key rollover/jamming issue, or you're just very confused. In none of these three circumstances is it an emulator bug however.

Priestyle commented 3 months ago

Um Endrift, you're saying that multi-select doesn't work on Emerald just like how you showed on your video of you trying to do it on Ruby? But on emerald, multi-select works on mgba. I'm really confused.

endrift commented 3 months ago

I'm saying that multi-select doesn't work on Ruby on hardware or in mGBA, but it does work on Emerald on both hardware and in mGBA. There's no discrepancy between hardware and mGBA, and therefore no bug.