search

mgeier / insipid-sphinx-theme

:yawning_face: An insipid theme for the Sphinx documentation generator.
https://insipid-sphinx-theme.readthedocs.io/
BSD 2-Clause "Simplified" License
39 stars 4 forks source link

Use only colors, no underlines for links #62

Closed hagenw closed 3 years ago

hagenw commented 3 years ago

Closes #59

As described in #59 you would present internal and external links visual different. I do not really like to use an icon for this, so I decided for a different color for internal links. I have now removed the underlines completely, and use a darker color when hovering. Already visited links are not presented in a different color any longer.

image

and repeating the part from the issue from the external repo:

image

I'm not completely convinced by th elight blue color for the internal links. But before searching for a better color, I first wanted to get feedback if the overall direction is ok ;)

mgeier commented 3 years ago

I'm not really convinced ...

I do like that visited links have a different shade of blue, I would even like to make this better visible, because it's kinda hard to see right now.

I do not really like to add another hue to the color palette. It's extremely hard to choose good colors (and there is certainly a lot of room for improvement in the current color selection), but each additional color becomes even harder, because it is supposed to fit in with all existing colors.

Another aspect is accessibility. I'm not an expert, but I assume that for many people the underline is easier to distinguish than a little change in hue.

As an alternative for getting rid of the dashed lines, what about doing something like #63?

hagenw commented 3 years ago

Yes, I'm also not convinced by adding another color. Usually, I don't have this problem as I don't bother distinguishing between external, internal and already visited links as I never needed that information.

The solution you proposed in #63 seems definitely the better option, I will close this pull request.