search

mgmgpyaesonewin / web-crawler-assignment

0 stars 0 forks source link

Start of the code review process 👋 #8

Open malparty opened 3 months ago

malparty commented 3 months ago

Hello Pyae, 👋

Thank you for your effort on the code submission. I am Xavier, Technical Lead at Nimble, and I am happy to be the reviewer for our code review session.

During the review process, I would like to know more about your decisions, so I will create issues in some areas where there could be more improvements regarding your submission. Since solving every possible problem would take too long, I will prioritize the most important ones.

At the same time, please keep in mind that this is a bi-directional process, and I would love to hear back from you as well. Therefore, do not hesitate to ask questions or share your opinions about the implementation (if any) during the process.

We expect the code review process to be completed within 2-3 days. As a result, please make sure you are responsive during this process. If you need more time, please let us know as soon as possible so we can plan accordingly.

If we are aligned on any issue, and you would like to correct them, please address the issue using a proper git flow (creating a new branch, opening a Pull Request (PR) per issue, and merging the code when you are ready), and I will follow up on those fixes. Just so you know, you don't have to close any of my created issues after merging your PRs; I will help verify and close them for you once they pass. 😇

In the end, I do hope that you find the process enjoyable. Good luck and happy coding. 🤘

mgmgpyaesonewin commented 3 months ago

Hello @malparty , 👋

It is nice meeting you here. Thank you for your time for reviewing my codes and for your guidance on the process. I appreciate the opportunity to learn and improve through this code review session.I would try to be active here as much as possible and will communicate if I need any additional time.

Happy to start fixing and improving the code. 🚀

malparty commented 3 months ago

Thanks a lot for your answers and details. I now have all the information I need and I will forward it to our recruitment team so they can follow up with you.

mgmgpyaesonewin commented 3 months ago

Hi @malparty,

Thank you for your information and reviews. Expect #12, I had updated and refactored my test cases and controllers. Let me also deployed my updated and work on it. I learned a lot from this reviews. Looking forward to more of them.

mgmgpyaesonewin commented 3 months ago

Hi @malparty

I received the update from HR. Unfortunately, I got rejected. I would like to seek for your guidance where I could be able to improve myself as I was able to learn from you during the review. Thank you.

malparty commented 3 months ago

Hi @mgmgpyaesonewin Thanks for your message 🙏🏼

The most important parts that can be improved have been raised in the other issues. Even when the issues were "questions", they underlined a possible improvement or need to complete a missing functionality.

I'd like to mention you had a very positive attitude and were reactive to answering all issues, which is a positive thing. Unfortunately, chose to move forward with another candidate who had fewer issues on the first submission.

Once again, thanks for your time & effort,

Xavier