search

mgolokhov / dodroid

May the knowledge be with you!
MIT License
20 stars 12 forks source link

squid:S2696 - Instance methods should not write to "static" fields #84

Closed georgekankava closed 8 years ago

georgekankava commented 8 years ago

This pull request is focused on resolving occurrence of Sonar rule squid:S2696 - Instance methods should not write to "static" fields. This pull request removes 40 minutes of technical debt. You can find more information about the issue here: https://dev.eclipse.org/sonar/rules/show/squid:S2696 Please let me know if you have any questions. George Kankava

mgolokhov commented 8 years ago

In general a good point about thread safety. In this case getVersion() is already getter (no need for setter) and it should be static. More over as utility function it should be moved to a proper package.