mgomes / api_auth

HMAC authentication for Rails and HTTP Clients
MIT License
480 stars 147 forks source link

forces request query param values to be escaped #162

Open DaKaZ opened 6 years ago

DaKaZ commented 6 years ago

This PR fixes issue #123 where query strings are handled differently based on combinations of different libraries.

DaKaZ commented 6 years ago

@fwininger I am sorry about that - I had a local helper which I did not include. Please see the new PR code attached which includes several new specs for testing. Note: I had to add Rails as a gemspec dependency since ActiveResource requires it. I am happy to make any changes you see fit, I am just trying to solve a issue affecting multiple people.

DaKaZ commented 6 years ago

@fwininger any additional thoughts?